Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extract_xcode.py instead of compiling pbzx #149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamscott
Copy link
Member

This PR adds extract_xcode.py to do what it says.

Capture d’écran, le 2024-08-22 à 09 09 17

For an unknown reason, as shown above, xar of the VM refuses to extract the Xcode_15.4.xip file on my MacBook Pro. (for the record, the SHA256 sum of the file is alright). But with extract_xcode.py, it works OK. As extract_xcode.py contains the pbzx algorithm, no need to compile the C project.

I suggest we replace the existing algorithm for compatibility reasons.

@adamscott adamscott added the bug Something isn't working label Aug 22, 2024
@adamscott adamscott force-pushed the add-extract_xcode-python-script branch 2 times, most recently from bf54cef to 6b6add6 Compare August 22, 2024 14:01
@adamscott adamscott force-pushed the add-extract_xcode-python-script branch from 6b6add6 to edf2ff2 Compare August 22, 2024 14:11
@adamscott adamscott added enhancement New feature or request and removed bug Something isn't working labels Aug 22, 2024
@adamscott adamscott requested a review from akien-mga August 22, 2024 14:12
@zynga-jpetersen
Copy link

zynga-jpetersen commented Sep 11, 2024

While this branch did get me passed the xar extract, which is great, I still wasnt able to compile osx, getting the following errors:

osx.log

-- Performing Test HAVE_CXX_FLAG_WD654
-- Performing Test HAVE_CXX_FLAG_WD654 - Failed
-- Performing Test HAVE_CXX_FLAG_WTHREAD_SAFETY
-- Performing Test HAVE_CXX_FLAG_WTHREAD_SAFETY - Failed
-- Performing Test HAVE_CXX_FLAG_COVERAGE
-- Performing Test HAVE_CXX_FLAG_COVERAGE - Success
-- Performing Test HAVE_GNU_POSIX_REGEX
-- Performing Test HAVE_GNU_POSIX_REGEX
-- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile

I have it working on my windows machine which is x86_64 suspect this doesnt build on aarch64 though I'm still unclear why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants