Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use special double entries in gdextension #62

Open
fire opened this issue Nov 7, 2024 · 3 comments
Open

Use special double entries in gdextension #62

fire opened this issue Nov 7, 2024 · 3 comments

Comments

@fire
Copy link
Member

fire commented Nov 7, 2024

Godot version

V-Sekai/godot@35b10e3

godot-cpp version

https://github.com/godotengine/godot-cpp/tree/fbbf9ec4efd8f1055d00edb8d926eef8ba4c2cce

System information

Macos

Issue description

Godot added a feature for the particular naming of the double extension libraries.

https://github.com/libriscv/godot-sandbox/blob/main/bin/addons/godot_sandbox/bin/godot-riscv.gdextension

godot-cpp-template does not use it. https://github.com/godotengine/godot-cpp-template/blob/main/demo/bin/example.gdextension

godot-cpp-template should use the special syntax. Note that the order of the double vs single matters.

@fire fire changed the title Migrate to macos.debug.double in gdextension Use special double entries in gdextension Nov 7, 2024
@Ivorforce
Copy link
Contributor

Ivorforce commented Nov 7, 2024

This is half addressed in #55, through the use of env["suffix"] in the naming scheme, which is defined here and (i think) intended for this purpose. The PR does not currently add new entries to the .gdextension file.

Edit: actually, godot-cpp-template already uses env["suffix"], which includes .double when relevant. We just need to add separate entries in the .gdextension to address your issue.

Still, i want to note that the naming scheme implies a few more missing combinations, such as .nothreads.

@fire
Copy link
Member Author

fire commented Nov 7, 2024

I downloaded
image
from https://github.com/godotengine/godot-cpp-template/actions/runs/11691017198/job/32557244884 doubles build.

godot-cpp-template.zip and it does not build doubles libEXTENSION-NAME.macos.template_debug, I suspect it is overwriting.

Secondly libEXTENSION-NAME.macos.template_debug is missing env["arch"]

@Ivorforce
Copy link
Contributor

Secondly libEXTENSION-NAME.macos.template_debug is missing env["arch"]

That one is actually fixed by #55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants