add flex layout for left nav container #10353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit makes the left nav a flex container. by doing that, it also removes the fixed calculation that happens in custom.js. that manual calculation makes parts of the left nav non-scrollable in e.g. "stable" mode of the docs. with this commit, any changes to the top portion of the left nav's height will not matter as the bottom part will flex on the available height automatically.
|
Closing this PR as commit 7a79288 closes the issue this PR was attached to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10352
this PR makes the left nav a flex container. by doing that, it also removes the manual calculation that happens in custom.js using fixed margin numbers. that manual calculation makes parts of the left nav non-scrollable in e.g. "stable" mode of the docs. with this PR, any changes to the top portion of the left nav's height will not matter as the bottom part will flex on the available height automatically.