Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool Vector Dead Link on 4.0 #6259

Open
2 tasks
TheYellowArchitect opened this issue Oct 5, 2022 · 2 comments · May be fixed by #10382
Open
2 tasks

Pool Vector Dead Link on 4.0 #6259

TheYellowArchitect opened this issue Oct 5, 2022 · 2 comments · May be fixed by #10382
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation bug

Comments

@TheYellowArchitect
Copy link
Contributor

TheYellowArchitect commented Oct 5, 2022

PoolVectorArrays were a thing in 3.x it seems
https://docs.godotengine.org/en/stable/classes/class_poolvector2array.html?highlight=poolvector2array

They don't exist in 4.x https://docs.godotengine.org/en/latest/classes/class_poolvector2array.html?highlight=poolvector2array
PackedVectorXArrays replaced them.

Yet, in the docs, there is still a location they are referenced:
https://docs.godotengine.org/en/latest/development/cpp/core_types.html?highlight=poolvector#allocating-memory
pool_vector.h especially is a dead link and has been long deleted. memory.h seems to have completely remade it to use MemoryStaticPool (can't confirm as I can't read the source code)

Related:

My suggestions to close this and the above issue:

@Calinou
Copy link
Member

Calinou commented Oct 5, 2022

Pool*Vector was replaced by Packed*Vector in 4.0. The documentation referencing them should be rewritten (not just renamed) as how packed vectors work internally is different from pooled vectors. You can find some information about it in Core refactoring progress report #1.

@skyace65 skyace65 added the area:contributing Issues and PRs related to the Contributing/Development section of the documentation label Dec 29, 2022
@tetrapod00
Copy link
Contributor

tetrapod00 commented Dec 5, 2024

#10329 removed the references to Pool*Array and PoolVector, but I'm leaving this open for now to track the documentation of alternatives to Vector<> in 4.x.

Redirects may be out of scope at this point, since we're so far into the 4.x release cycle.

@tetrapod00 tetrapod00 linked a pull request Dec 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants