Add samplerExternalOES type to variable types of shading language
#10299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
force-pushed
the
shader_new_uniform_type
branch
from
56bb930 to
9622093
Compare
dsnopek
reviewed
Nov 21, 2024
Comment on lines
1028
to
1032
| | **samplerExternalOES** | **ExternalTexture** | External texture. | | ||
| | | | Only supported in Compatibility/Android platform. | |
There was a problem hiding this comment.
We don't need to say it here now (because we don't support Vulkan yet), but just a note about when we do eventually add support for Vulkan: it can use sampler2D for external textures which is what samplerExternalOES is translated to on Vulkan, so if you use samplerExternalOES, you'll be able to write a shader that'll work both on OpenGL and Vulkan.
|
This should be added to the table of data types at the top of the Shading Language page, too. Looks like you only added it to the table comparing GDScript types |
Chaosus
force-pushed
the
shader_new_uniform_type
branch
from
9622093 to
e4fcb8c
Compare
Chaosus
force-pushed
the
shader_new_uniform_type
branch
from
e4fcb8c to
c46c219
Compare
|
@tetrapod00 Check again, I think I've fixed it. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reflect change from godotengine/godot#96982