-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port physics interpolation docs from 3.6 #10359
Conversation
6bd82eb
to
958b4c9
Compare
tutorials/physics/interpolation/2d_and_3d_physics_interpolation.rst
Outdated
Show resolved
Hide resolved
tutorials/physics/interpolation/2d_and_3d_physics_interpolation.rst
Outdated
Show resolved
Hide resolved
and the smoothest possible experience. | ||
|
||
Exceptions to automatic physics interpolation | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it matters for rendering the page, but at least for consistency, we should use the order for header syntax that is standard in other pages:
Page title
==========
Header
------
Sub-header
~~~~~~~~~~
Sub-sub-header
^^^^^^^^^^^^^^
This page uses ^^^
for everything, so all those should use ---
instead. And you should consider using subheaders with ~~~
for some of the headers below Cameras
, since they're all meaningfully related. UNLESS you are intentionally trying to keep everything at the same header level so it shows up in the sidebar.
The other pages here need similar changes. If you want specific suggestions for exactly which header syntax to use for each I can make individual suggestions for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can also be done in a later PR without breaking translations, so feel free to ignore and defer this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll implement this, and change all the ^^^^
to ~~~~
Camera every frame in ``_process()`` to look at a target node (such as the player). | ||
|
||
But there is a problem. If we use the traditional ``get_global_transform()`` on a | ||
Camera "target" Node, this transform will only focus the Camera on the target *at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Camera "target" Node, this transform will only focus the Camera on the target *at | |
Camera "target" node, this transform will only focus the Camera on the target *at |
"Node" usually not capitalized in most cases since its very common.
Honestly "Camera" may or may not need to be capitalized either thoughout this page, but that case is more subjective and I understand why it currently is capitalized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Camera" was probably capitalized because that was what "Camera3D" was named in 3.x. I'll go through and change it as applicable.
tutorials/physics/interpolation/physics_interpolation_introduction.rst
Outdated
Show resolved
Hide resolved
tutorials/physics/interpolation/physics_interpolation_introduction.rst
Outdated
Show resolved
Hide resolved
tutorials/physics/interpolation/using_physics_interpolation.rst
Outdated
Show resolved
Hide resolved
tutorials/physics/interpolation/using_physics_interpolation.rst
Outdated
Show resolved
Hide resolved
First batch of suggestions. I'll try to come back and look again after building this locally. We could probably merge this as-is though, since it is pretty good already and already exists in the 3.6 docs. We definitely shouldn't delay this to after the release of 4.4 |
tutorials/physics/interpolation/physics_interpolation_introduction.rst
Outdated
Show resolved
Hide resolved
tutorials/physics/interpolation/physics_interpolation_quick_start_guide.rst
Outdated
Show resolved
Hide resolved
tutorials/physics/interpolation/physics_interpolation_quick_start_guide.rst
Outdated
Show resolved
Hide resolved
tutorials/physics/interpolation/advanced_physics_interpolation.rst
Outdated
Show resolved
Hide resolved
tutorials/physics/interpolation/advanced_physics_interpolation.rst
Outdated
Show resolved
Hide resolved
tutorials/physics/interpolation/advanced_physics_interpolation.rst
Outdated
Show resolved
Hide resolved
958b4c9
to
5e7cddb
Compare
I've applied changes based on tetrapod's review. The one section that used uppercase "Camera" everywhere is now using either "Camera3D" or "camera". I'd appreciate someone else looking it over to make sure everything flows right, it seems kinda weird to switch back and forth. |
tutorials/physics/interpolation/physics_interpolation_quick_start_guide.rst
Outdated
Show resolved
Hide resolved
5e7cddb
to
6b4a2c9
Compare
Fixed |
Thank you, great work! Merged. |
This is a copied and modified version of the physics interpolation docs from the 3.6 branch of the documentation. 2D physics interpolation exists in 4.3, however 3D interpolation only exists in 4.4 so this can't be cherry picked.
Changes I've made compared to the 3.6 version of these pages