Fix outdated function names in GUI skinning example code #10368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the function to override theme font color from "add_color_override" to "add_theme_color_override", as the previous version is not recognized by my 4.3 Godot Editor. Judging by the documentation archives, it seems that "add_color_override" was the version used in Godot 3. From Control's 4.3 documentation, it seems C# functions have also been updated to include Theme in their name. It would make sense, so I updated it too, but I'm not 100% sure it actually works this way.
tetrapod00
approved these changes
Dec 4, 2024
tetrapod00
added
bug
area:manual
tetrapod00
changed the title
mhilbrunner
approved these changes
Dec 5, 2024
|
Merged. Thanks and congrats on your first merged contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the function to override theme font color from "add_color_override" to "add_theme_color_override", as the previous version is not recognized by my 4.3 Godot Editor.
Judging by the documentation archives, it seems that "add_color_override" was the version used in Godot 3.
From Control's 4.3 documentation, it seems C# functions have also been updated to include Theme in their name. It would make sense, so I updated it too, but I'm not 100% sure it actually works this way.