Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracker] CSG issues #100164

Open
7 of 11 tasks
fire opened this issue Dec 8, 2024 · 1 comment
Open
7 of 11 tasks

[Tracker] CSG issues #100164

fire opened this issue Dec 8, 2024 · 1 comment

Comments

@fire
Copy link
Member

fire commented Dec 8, 2024

Tested versions

  • Reproducible in Master aa8d9b8
  • Not reproducible in 4.3

System information

Windows 11, Nvidia 4000 series

Issue description

The 4.4 CSG update is crucial for projects that need help building 3D design tools in the engine and their game. This 4.4 CSG update serves the core mission of an accessible game engine, and it would be a shame to revert to the 4.3 CSG.

Previously, the 4.3 CSG feature did not handle mesh subtraction and intersection well. Mesh addition was handled decently, although it had some corrupted triangles.

In 4.4, CSG was improved so that mesh subtraction, intersection and addition work, with the requirement that all input meshes must be manifold as defined by the original CSG work https://godotengine.org/article/godot-gets-csg-support/ in 2018.

Issues and Pull Requests

Summary: Crash bugs are fixed. Most of the CSGMesh3D inputs from Mesh primitives have fixes incoming. We found a workaround for topologically zero-volume (quad and plane) meshes, but not RibbonTrailMesh.

Since 2018, many other types of Mesh have been added; although they were allowed to be placed in the CSGMesh3D, applying CSG to them wasn't mathematically sound.

The general workflow is that developers design models using the CSG Sphere, Box, Cylinder (Cone), Torus, and Polygon (Depth, Path and Spin). If developers can create manifold 3D meshes, they can also use them in CSGMesh3D secondarily.

Additional

Feel free to edit the issue to add more.

Steps to reproduce

This is a tracker.

Minimal reproduction project (MRP)

The contained bugs have MRPs.

@fire
Copy link
Member Author

fire commented Dec 13, 2024

Worked on Push some warnings for CSG non manifold and other errors. #100361

@fire fire self-assigned this Dec 17, 2024
@AThousandShips AThousandShips changed the title CSG Tracker [Tracker] CSG issues Dec 17, 2024
@fire fire removed their assignment Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Very Bad
Status: No status
Development

No branches or pull requests

3 participants