-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash with CSGPolygon3D in Spin mode #99888
Comments
Investigating |
|
Mine is almost the same:
|
Waiting for elalish/manifold#1040 to be completed, but the cause of the crash was identified as:
|
To be clear, I have not at all identified (or even reproduced) a crash yet. |
Maybe unrelated but I also noticed crashes in master when dragging the finicky CSG editor handles e.g. CSGBox3D size handles in the editor. Just spawn a single CSGBox3D node and try to drag the editor handles for its size adjustment. I dont know what data we are feeding to the poor manifold but it does not seem to like such non-geometry input so such input should likely be already skipped on the editor side. |
I want to do it at least if the mesh is not manifold, avoid crashing, and return the empty mesh. |
Is there a easy to code way to verify non manifold without constructing a Manifold:manifold? |
Tested versions
Reproducible in: 893bbdf
Not reproducible in: d09d82d
I bisected the crash and it seems to be introduced in fda444b from #94321.
System information
Godot v4.4.dev (893bbdf) - openSUSE Tumbleweed 20241022 on X11 - X11 display driver, Multi-window, 1 monitor - OpenGL 3 (Compatibility) - AMD Radeon RX 5700 XT (radeonsi, navi10, LLVM 18.1.8, DRM 3.59, 6.11.3-2-default) - AMD Ryzen 7 3700X 8-Core Processor (16 threads)
Issue description
A CSGPolygon3D in the scene with the mode set to Spin will crash the editor.
Steps to reproduce
The editor will crash at step 4.
Alternatively try to open the MRP.
Minimal reproduction project (MRP)
MRP: this-csg-crashes-the-editor.zip
The text was updated successfully, but these errors were encountered: