From 1082dde5467d845a2b00cb911ca0ee81e61d7b73 Mon Sep 17 00:00:00 2001 From: Rob Findley Date: Mon, 25 Sep 2023 09:39:54 -0400 Subject: [PATCH] cmd/bench: increase timeout for gopls tests to 180m MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With recently added benchmarks, gopls benchmarks are starting to time out. Increase to 180m for now; we'll revisit if the benchmarks can be made faster. Change-Id: I2f60a8b606bebaaffac347173bdd064646e2a5fc Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/530915 Auto-Submit: Robert Findley Reviewed-by: Nooras Saba‎ LUCI-TryBot-Result: Go LUCI --- cmd/bench/gotest.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/bench/gotest.go b/cmd/bench/gotest.go index 9833de2..83d845d 100644 --- a/cmd/bench/gotest.go +++ b/cmd/bench/gotest.go @@ -68,7 +68,7 @@ func goTestSubrepo(tc *toolchain, subRepo, baselineDir, experimentDir string) er fmt.Printf("toolchain: %s\n", test.name) // set the toolchain tag goplsPath := filepath.Join(test.goplsDir, "gopls") - err = tc.Do(benchmarkDir, "test", "-short", "-bench=.", fmt.Sprintf(`-gopls_path=%s`, goplsPath), "-count=5", "-timeout=60m") + err = tc.Do(benchmarkDir, "test", "-short", "-bench=.", fmt.Sprintf(`-gopls_path=%s`, goplsPath), "-count=5", "-timeout=180m") if err != nil { return fmt.Errorf("error running sub-repo %s benchmark %q with toolchain %s in dir %s: %w", subRepo, test.name, tc.Name, benchmarkDir, err) }