Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu: support darwin/arm64 CPU feature detection #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

howjmay
Copy link

@howjmay howjmay commented Jul 3, 2021

Support ARM64 features detection. The CPU features which are supported by
Apple Silicon M1 are assumed as the minimal set of features for Go programs
running on darwin/arm64.

The ARM64 supporting features are referred to
https://en.wikichip.org/wiki/arm/armv8#ARMv8_Extensions_and_Processor_Features

close golang/go#42747

@google-cla google-cla bot added the cla: yes label Jul 3, 2021
@gopherbot
Copy link

This PR (HEAD: 107027e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@howjmay howjmay force-pushed the detect-apple-m1-features branch from 107027e to 1ba4687 Compare July 3, 2021 17:57
@gopherbot
Copy link

This PR (HEAD: 1ba4687) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Martin Möhrmann:

Patch Set 4:

(7 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

@howjmay howjmay force-pushed the detect-apple-m1-features branch from 1ba4687 to c3be48e Compare July 7, 2021 01:28
@gopherbot
Copy link

This PR (HEAD: c3be48e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@howjmay howjmay force-pushed the detect-apple-m1-features branch from c3be48e to cfc9f86 Compare July 7, 2021 01:32
@gopherbot
Copy link

This PR (HEAD: cfc9f86) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@howjmay howjmay force-pushed the detect-apple-m1-features branch 2 times, most recently from 021ce95 to e57cd24 Compare July 7, 2021 01:34
@gopherbot
Copy link

This PR (HEAD: e57cd24) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@howjmay howjmay force-pushed the detect-apple-m1-features branch from e57cd24 to dbeb491 Compare July 7, 2021 01:35
@gopherbot
Copy link

This PR (HEAD: dbeb491) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@howjmay howjmay force-pushed the detect-apple-m1-features branch from dbeb491 to 76cf32c Compare July 7, 2021 02:58
@gopherbot
Copy link

This PR (HEAD: 76cf32c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Hau Yang:

Patch Set 4:

(5 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Hau Yang:

Patch Set 9:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

@howjmay howjmay changed the title cpu: support darwin/arm64 CPU feature detection cpu: extend arm64 CPU feature detection Jul 7, 2021
@howjmay howjmay changed the title cpu: extend arm64 CPU feature detection cpu: extend arm64 support on CPU feature detection Jul 7, 2021
@gopherbot
Copy link

Message from Martin Möhrmann:

Patch Set 10:

(8 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

@howjmay howjmay force-pushed the detect-apple-m1-features branch from 76cf32c to a305a6c Compare July 7, 2021 16:03
@howjmay howjmay changed the title cpu: extend arm64 support on CPU feature detection cpu: support darwin/arm64 CPU feature detection Jul 7, 2021
@gopherbot
Copy link

This PR (HEAD: a305a6c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@howjmay howjmay force-pushed the detect-apple-m1-features branch from a305a6c to 7244160 Compare July 7, 2021 16:22
@gopherbot
Copy link

This PR (HEAD: 7244160) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Hau Yang:

Patch Set 12:

(8 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

@howjmay howjmay force-pushed the detect-apple-m1-features branch from 7244160 to 54c2df7 Compare July 10, 2021 09:15
@gopherbot
Copy link

This PR (HEAD: 54c2df7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@howjmay howjmay force-pushed the detect-apple-m1-features branch from 54c2df7 to 7942793 Compare July 10, 2021 09:46
@gopherbot
Copy link

This PR (HEAD: 7942793) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Hau Yang:

Patch Set 9:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Martin Möhrmann:

Patch Set 10:

(8 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Hau Yang:

Patch Set 12:

(8 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

Support ARM64 features detection. The CPU features which are supported by
Apple Silicon M1 are assumed as the minimal set of features for Go programs
running on darwin/arm64.

The ARM64 supporting features are referred to
https://en.wikichip.org/wiki/arm/armv8#ARMv8_Extensions_and_Processor_Features
@howjmay howjmay force-pushed the detect-apple-m1-features branch from 7942793 to 44d7b39 Compare September 4, 2022 12:32
@gopherbot
Copy link

Message from Eric Lagergren:

Patch Set 14:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Daniel Martí:

Patch Set 14:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Eric Lagergren:

Patch Set 14:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Daniel Martí:

Patch Set 14:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Koichi Shiraishi:

Patch Set 14:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 44d7b39) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Hau Yang:

Patch Set 14:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

internal/cpu: support darwin/arm64 CPU feature detection [freeze exception]
2 participants