Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable cache key #1056

Open
2 tasks done
silverwind opened this issue Jun 5, 2024 · 2 comments
Open
2 tasks done

Configurable cache key #1056

silverwind opened this issue Jun 5, 2024 · 2 comments

Comments

@silverwind
Copy link

silverwind commented Jun 5, 2024

Welcome

  • Yes, I understand that the GitHub action repository is not the repository of golangci-lint itself.
  • Yes, I've searched similar issues on GitHub and didn't find any.

Your feature request related to a problem? Please describe.

I would like to include the values of GOARCH, GOARM, GOOS and the --build-tags argument into the cache key which is not possible because the cache key is hardcoded.

Describe the solution you'd like.

A cache-key option to define a custom cache key.

Describe alternatives you've considered.

None

Additional context.

No response

@silverwind
Copy link
Author

silverwind commented Jun 5, 2024

I think I'll be using actions/cache directly to have full control over that cache, but other users might be interested in such an option.

@ldez
Copy link
Member

ldez commented Jun 6, 2024

Golangci-lint should not be used from a platform to target another platform (GOOS, GOARCH, ...)

Golangci-lint is not Go.

You can influence the analysis by playing with the GOOS or GOARCH but golangci-lint is compiled for a specific OS, so some pieces, related to the other OS, can be missing and lead to unexpected behavior.

#742 (comment)
#624 (comment)

@ldez ldez added the proposal label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants