Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: in-platform notification channels #5612

Merged
merged 1 commit into from
Nov 28, 2024
Merged

feat: in-platform notification channels #5612

merged 1 commit into from
Nov 28, 2024

Conversation

kandl
Copy link
Contributor

@kandl kandl commented Nov 27, 2024

  • Add new feature flag for in-platform notification channels.
  • Hide in-platform notification channels behind the feature flag.
  • Add assertNever utility type for safe exhaustiveness checks.
  • Align notification channels with our model/spi conventions.
  • Add possibility to query / filter notification channels.
  • Make convertors safer (when converting unknown notification channel, it's filtered now - before it thrown error).
  • Adjust all usages of notification channels to new model.

risk: low
JIRA: F1-928


Important

Please, don't forget to run rush change for the commits that introduce new features 🙏


Refer to documentation to see how to run checks and tests in the pull request. This is the list of the most used commands:

extended test - backstop
extended test - tiger-cypress - integrated
extended test - tiger-cypress - isolated
extended test - tiger-cypress - record

@kandl kandl added ready to review PR is ready to final code review publish pre-release labels Nov 27, 2024
@hackerstanislav hackerstanislav added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@kandl kandl added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@kandl kandl added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@kandl
Copy link
Contributor Author

kandl commented Nov 27, 2024

extended test - tiger-cypress - record

@gooddata
Copy link

gooddata bot commented Nov 27, 2024

Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2344/ finished with 'FAILURE' status.

@kandl
Copy link
Contributor Author

kandl commented Nov 27, 2024

extended test - tiger-cypress - record

@gooddata
Copy link

gooddata bot commented Nov 27, 2024

Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2345/ finished with 'FAILURE' status.

@kandl
Copy link
Contributor Author

kandl commented Nov 27, 2024

extended test - tiger-cypress - record

@gooddata
Copy link

gooddata bot commented Nov 27, 2024

Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2346/ finished with 'FAILURE' status.

@kandl kandl added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@kandl
Copy link
Contributor Author

kandl commented Nov 28, 2024

extended test - tiger-cypress - record

@yenkins
Copy link

yenkins commented Nov 28, 2024

@yenkins
Copy link

yenkins commented Nov 28, 2024

✨ Cypress test results ✨

🎉 Great news! Tests were successful.

Status Name Tests Failures Time
crossFiltering.spec.ts 1 - 14.988s
dashboardBasicActions.spec.ts 2 - 13.650s
dashboardRichText.spec.ts 5(2 skipped) - 13.884s
dashboardScatterPlot.spec.ts 1 - 8.114s
dashboardTiger.spec.ts 12(6 skipped) - 25.563s
dashboardTigerWithCharts.spec.ts 2(1 skipped) - 10.082s
dependentFilters.spec.ts 6(4 skipped) - 98.465s
dragDropAndMoveWidget.spec.ts 4(2 skipped) - 23.511s
headerSection.spec.ts 4(2 skipped) - 13.259s
hideFilters.spec.ts 12 - 76.977s
hideFiltersTooltips.spec.ts 8 - 60.771s
insightOnDashboard.spec.ts 9(4 skipped) - 35.276s
multipleDateFilters.spec.ts 5 - 34.740s
unknownVisualization.spec.ts 1 - 5.842s
manyData.spec.ts 2 - 11.575s
scatterPlot.spec.ts 2 - 8.211s

You can find full report here.

@gooddata
Copy link

gooddata bot commented Nov 28, 2024

Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2349/ finished with 'FAILURE' status.

- Add new feature flag for in-platform notification channels.
- Hide in-platform notification channels behind the feature flag.
- Add `assertNever` utility type for safe exhaustiveness checks.
- Align notification channels with our model/spi conventions.
- Add possibility to query / filter notification channels.
- Make convertors safer (when converting unknown notification channel,
it's filtered now - before it thrown error).
- Adjust all usages of notification channels to new model.

risk: low
JIRA: F1-928
@kandl
Copy link
Contributor Author

kandl commented Nov 28, 2024

extended test - tiger-cypress - isolated

@gooddata
Copy link

gooddata bot commented Nov 28, 2024

Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2350/ finished with 'FAILURE' status.

@kandl kandl added this pull request to the merge queue Nov 28, 2024
Merged via the queue into master with commit 8c239af Nov 28, 2024
6 checks passed
@kandl kandl deleted the mkn-f1-928 branch November 28, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
publish pre-release ready to review PR is ready to final code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants