-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: in-platform notification channels #5612
Conversation
9174a82
to
03f3a60
Compare
extended test - tiger-cypress - record |
Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2344/ finished with 'FAILURE' status. |
extended test - tiger-cypress - record |
Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2345/ finished with 'FAILURE' status. |
extended test - tiger-cypress - record |
Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2346/ finished with 'FAILURE' status. |
extended test - tiger-cypress - record |
Cypress recording succeeded 🎉 Here is your new recording: https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-cypress-tiger-record-zuul/221/artifact/libs/sdk-ui-tests-e2e/recordings/mappings/TIGER/*zip*/archive.zip |
✨ Cypress test results ✨🎉 Great news! Tests were successful.
You can find full report here. |
Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2349/ finished with 'FAILURE' status. |
- Add new feature flag for in-platform notification channels. - Hide in-platform notification channels behind the feature flag. - Add `assertNever` utility type for safe exhaustiveness checks. - Align notification channels with our model/spi conventions. - Add possibility to query / filter notification channels. - Make convertors safer (when converting unknown notification channel, it's filtered now - before it thrown error). - Adjust all usages of notification channels to new model. risk: low JIRA: F1-928
extended test - tiger-cypress - isolated |
Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2350/ finished with 'FAILURE' status. |
assertNever
utility type for safe exhaustiveness checks.risk: low
JIRA: F1-928
Important
Please, don't forget to run
rush change
for the commits that introduce new features 🙏Refer to documentation to see how to run checks and tests in the pull request. This is the list of the most used commands: