Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two CIFs cannot be converted to pymatgen objects #12

Open
esoteric-ephemera opened this issue Dec 22, 2023 · 3 comments
Open

Two CIFs cannot be converted to pymatgen objects #12

esoteric-ephemera opened this issue Dec 22, 2023 · 3 comments

Comments

@esoteric-ephemera
Copy link

A very minor issue, but two CIFs with IDs = 0e2d8f26d6, cdc06a1a2a cannot be converted to pymatgen Structure objects as of pymatgen==2023.12.18.

They're still parsable with pymatgen.io.cif.CifParser, but trying to call get_structures on the CifParser object, or directly calling pymatgen.core.Structure.from_file on these CIFs throws ValueError: Invalid CIF file with no structures!

@ml-evs
Copy link

ml-evs commented Jan 17, 2024

I also ran into these: they correspond to structures that have overlapping atoms in the CIF (and thus incorrect presented formulae) and pathological energies. See e.g., https://optimade-gnome.odbx.science/v1/structures?filter=id=%22data/gnome_data/by_id.zip/data/gnome_data/by_id/0e2d8f26d6.CIF%22

@esoteric-ephemera
Copy link
Author

Thanks @ml-evs! Any chance you've noticed other CIFs with overlapping atomic sites?

@ml-evs
Copy link

ml-evs commented Jan 18, 2024

Not off-hand, but if you filter for things with unrealistic formation energies (like lower than -10 eV/atom) you'll probably find some: https://optimade-gnome.odbx.science/v1/structures?filter=_gnome_formation_energy_per_atom<-8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants