-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding algorithm TD Learning with N-Tuple Networks for 2048 #1107
Conversation
Cool! We had quite a big refactor committed to the master branch yesterday. Could you pull changes from master and commit the merge (or rebase)? We basically just moved all the games into subdirectories. I cannot run the tests while there are conflicts. |
Sure. Rebased now 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you lint your code by following Step 9 in the Adding a New Game on this page? https://github.com/deepmind/open_spiel/blob/master/docs/developer_guide.md
It greatly reduced the load on our end to have the code formatted as required by Google python standards.
E.g. indentation should be two spaces, not four. Etc.
|
Hi @Jazeem, Can you respond to the conversations above (or resolve them now if they are resolved) |
Have resolved them |
An algorithm that can win at 2048 without using tree search or hand crafted state evaluator functions.
Currently the code is somewhat coupled with 2048. It is possible to decouple it, if that is valuable for open_spiel. Will have to find a way to move n_tuples into game.
Have modified the game 2048 to consider a move that doesn't change the board as invalid
Implementation is similar to https://github.com/moporgic/TDL2048-Demo