Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct comment in issue #1111 #1112

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Correct comment in issue #1111 #1112

merged 1 commit into from
Aug 28, 2023

Conversation

JimZhouZZY
Copy link
Contributor

Correct the comments showing EntropySchedule example. Line 45

=>   [0, 3, 6, 11, 16, 21, 26, 10]

Modified to

=>   [0, 3, 6, 11, 16, 21, 26, 36]

@JimZhouZZY
Correct comment
6aee459 
Correct the comments showing EntropySchedule example.
Line 45
```
=>   [0, 3, 6, 11, 16, 21, 26, 10]
```
Modified to
```
=>   [0, 3, 6, 11, 16, 21, 26, 36]
```
@google-cla
Copy link

google-cla bot commented Aug 27, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lanctot
Copy link
Collaborator

lanctot commented Aug 27, 2023

Thanks! Can you sign the CLA?

@JimZhouZZY
Copy link
Contributor Author

Thanks! Can you sign the CLA?

Signed :)

@JimZhouZZY JimZhouZZY changed the title Correct comment Correct comment in issue #1111 Aug 27, 2023
@lanctot lanctot added the imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! label Aug 28, 2023
@lanctot
Copy link
Collaborator

lanctot commented Aug 28, 2023

Great. I have imported it and discussing with the team.

@lanctot lanctot added the merged internally The code is now submitted to our internal repo and will be merged in the next github sync. label Aug 28, 2023
@lanctot lanctot merged commit 8020207 into google-deepmind:master Aug 28, 2023
@lanctot lanctot mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JimZhouZZY @lanctot