Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote pawn to queen if pawn can promote #818

Merged
merged 1 commit into from
May 9, 2022

Conversation

acxz
Copy link
Contributor

@acxz acxz commented Apr 21, 2022

stay consistant with APL's rbc

Address 5) of #811

@acxz
Copy link
Contributor Author

acxz commented Apr 21, 2022

@lanctot I feel that the ci failures are unrelated. Can you confirm?

@lanctot
Copy link
Collaborator

lanctot commented Apr 21, 2022

Yeah seems like our chex version is causing issues. There may have been a recent backport or change in an unpinned dependency causing issues.

I am on vacation at the moment, so will look into it more deeply next week. I will probably include the change with the rest of the dep version changes in #807

@acxz
Copy link
Contributor Author

acxz commented Apr 21, 2022

thx for the quick glance, plz enjoy ur vacation, this work is not a high priority at the moment

@lanctot
Copy link
Collaborator

lanctot commented Apr 22, 2022

Tried a quick hack in #819 but no dice, will likely have to wait for all the other version upgrades. Sorry about that!

@lanctot
Copy link
Collaborator

lanctot commented Apr 26, 2022

Hi @acxz, the CI tests are now fixed on the master branch. Can you pull changes and push the merge to trigger a new invocation of the tests? Thanks!

stay consistant with APL's rbc
@lanctot lanctot added the imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! label May 6, 2022
@OpenSpiel OpenSpiel merged commit b938000 into google-deepmind:master May 9, 2022
@acxz acxz deleted the rbc-pawn-promote branch May 9, 2022 14:54
@acxz acxz restored the rbc-pawn-promote branch September 5, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants