Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to build/install from source with v2? #219

Open
samuela opened this issue Sep 8, 2021 · 2 comments
Open

How to build/install from source with v2? #219

samuela opened this issue Sep 8, 2021 · 2 comments

Comments

@samuela
Copy link

samuela commented Sep 8, 2021

It appears as though the v2 branch has removed docs/INSTALL.md, install.sh, BUILD and the :install bazel target. Here's the full diff between versions 1.33 and 2.0.0: v1.33...v2.0.0. What are the official steps to build 2.0.0 and later versions from source? Is there a convenient way to build them into a wheel?

Also, is the v2 or the master branch the main development branch?

@tomhennigan
Copy link
Collaborator

Sonnet v2 is a pure python library (unlike Sonnet 1) so building into a whl is the standard Python stanza: python setup.py sdist bdist_wheel. No need to use bazel for building Sonnet 2.

The v2 branch is the latest, master contains Sonnet 1 and no further development effort is planned there. I have been meaning to rename master to v1 for a while, I will check with the other maintainers and see about doing that today.

@samuela
Copy link
Author

samuela commented Sep 8, 2021

I attempted packaging via bdist_wheel but for some reason the test suite was failing (via pytest). I don't remember the exact details. I'll have to give it another shot and paste the error here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants