From a9261a5a048e9c008325f9c394dd62c9e2d1f7e8 Mon Sep 17 00:00:00 2001 From: JGStew Date: Thu, 20 Jun 2024 17:32:39 -0400 Subject: [PATCH 1/6] Update post.ts fix spelling error Signed-off-by: JGStew --- src/post.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/post.ts b/src/post.ts index c7c4994e..97730540 100644 --- a/src/post.ts +++ b/src/post.ts @@ -34,7 +34,7 @@ export async function run(logger: Logger) { // Look up the credentials path, if one exists. Note that we only check the // environment variable set by our action, since we don't want to - // accidentially clean up if someone set GOOGLE_APPLICATION_CREDENTIALS or + // accidentally clean up if someone set GOOGLE_APPLICATION_CREDENTIALS or // another environment variable manually. const credentialsPath = process.env['GOOGLE_GHA_CREDS_PATH']; if (!credentialsPath) { From d9925d9813b21d1d3a9b0ef7d9fc5fb475b1b6d3 Mon Sep 17 00:00:00 2001 From: JGStew Date: Thu, 20 Jun 2024 17:34:04 -0400 Subject: [PATCH 2/6] Update TROUBLESHOOTING.md fix spelling mistakes in troubleshooting Signed-off-by: JGStew --- docs/TROUBLESHOOTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/TROUBLESHOOTING.md b/docs/TROUBLESHOOTING.md index 27f022fa..73fac9f6 100644 --- a/docs/TROUBLESHOOTING.md +++ b/docs/TROUBLESHOOTING.md @@ -9,7 +9,7 @@ > [!CAUTION] > > Enabling debug logging increases the chances of a secret - > being accidentially logged. While GitHub Actions will scrub secrets, + > being accidentally logged. While GitHub Actions will scrub secrets, > please take extra caution when sharing these debug logs in publicly > accessible places like GitHub issues. > @@ -81,7 +81,7 @@ token", it means admission into the Workload Identity Pool failed. Check your [**Attribute Conditions**][attribute-conditions]. - - If the error message inclues "Failed to generate OAuth 2.0 Access + - If the error message includes "Failed to generate OAuth 2.0 Access Token", it means Service Account Impersonation failed. Check your [**Service Account Impersonation**][sa-impersonation] settings and ensure the principalSet is correct. From 9dc4bec92440d6d6ca7de59c283e7dc2310a4e15 Mon Sep 17 00:00:00 2001 From: JGStew Date: Thu, 20 Jun 2024 17:34:59 -0400 Subject: [PATCH 3/6] Update README.md fix spelling error Signed-off-by: JGStew --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 131d1ea3..7373e96f 100644 --- a/README.md +++ b/README.md @@ -618,7 +618,7 @@ as a secret. > [!CAUTION] > > Google Cloud Service Account Key JSON files must be secured -> and treated like a password. Anyone with acess to the JSON key can +> and treated like a password. Anyone with access to the JSON key can > authenticate to Google Cloud as the underlying Service Account. By default, > these credentials never expire, which is why the former authentication options > are much preferred. From d09a7e245b17497fc75656b52ab15fe770b7bb9d Mon Sep 17 00:00:00 2001 From: JGStew Date: Thu, 20 Jun 2024 17:35:46 -0400 Subject: [PATCH 4/6] Update action.yml fix spelling errors Signed-off-by: JGStew --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 78ae4ccf..0c527c29 100644 --- a/action.yml +++ b/action.yml @@ -143,7 +143,7 @@ inputs: description: |- Number of times to retry a failed authentication attempt. This is useful for automated pipelines that may execute before IAM permissions are fully - propogated. + propagated. deprecationMessage: |- This field is no longer used and will be removed in a future release. required: false From 565605fa10fe04fe21a1c2d4e869143c289506e3 Mon Sep 17 00:00:00 2001 From: JGStew Date: Thu, 20 Jun 2024 18:04:39 -0400 Subject: [PATCH 5/6] Create codespell.yml add automatic spell checking Signed-off-by: JGStew --- .github/workflows/codespell.yml | 41 +++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 .github/workflows/codespell.yml diff --git a/.github/workflows/codespell.yml b/.github/workflows/codespell.yml new file mode 100644 index 00000000..54bfd242 --- /dev/null +++ b/.github/workflows/codespell.yml @@ -0,0 +1,41 @@ +# Copyright 2023 Google LLC +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: 'codespell' + +on: + pull_request: + branches: + - 'main' + - 'release/**/*' + workflow_dispatch: + +concurrency: + group: '${{ github.workflow }}-${{ github.head_ref || github.ref }}' + cancel-in-progress: true + +defaults: + run: + shell: 'bash' + +jobs: + codespell: + name: 'codespell' + runs-on: 'ubuntu-latest' + + steps: + - uses: 'actions/checkout@v4' + - uses: 'codespell-project/actions-codespell@v2' + with: + only_warn: 1 From 6e501e59fde897db620a65ebe379b7bb6ba6cf71 Mon Sep 17 00:00:00 2001 From: Seth Vargo Date: Fri, 21 Jun 2024 11:31:28 -0400 Subject: [PATCH 6/6] Update spelling and versions --- .github/workflows/codespell.yml | 41 --------------------------- .github/workflows/release.yml | 3 +- .github/workflows/troubleshooting.yml | 2 +- 3 files changed, 3 insertions(+), 43 deletions(-) delete mode 100644 .github/workflows/codespell.yml diff --git a/.github/workflows/codespell.yml b/.github/workflows/codespell.yml deleted file mode 100644 index 54bfd242..00000000 --- a/.github/workflows/codespell.yml +++ /dev/null @@ -1,41 +0,0 @@ -# Copyright 2023 Google LLC -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -name: 'codespell' - -on: - pull_request: - branches: - - 'main' - - 'release/**/*' - workflow_dispatch: - -concurrency: - group: '${{ github.workflow }}-${{ github.head_ref || github.ref }}' - cancel-in-progress: true - -defaults: - run: - shell: 'bash' - -jobs: - codespell: - name: 'codespell' - runs-on: 'ubuntu-latest' - - steps: - - uses: 'actions/checkout@v4' - - uses: 'codespell-project/actions-codespell@v2' - with: - only_warn: 1 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 7a233ca4..51066eb9 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -22,6 +22,7 @@ on: jobs: release: - if: "startsWith(github.event.head_commit.message, 'Release: v')" + if: |- + ${{ startsWith(github.event.head_commit.message, 'Release: v') }} name: 'Release' uses: 'google-github-actions/.github/.github/workflows/release.yml@v0' diff --git a/.github/workflows/troubleshooting.yml b/.github/workflows/troubleshooting.yml index 338b1374..d601bfc3 100644 --- a/.github/workflows/troubleshooting.yml +++ b/.github/workflows/troubleshooting.yml @@ -27,7 +27,7 @@ jobs: runs-on: 'ubuntu-latest' steps: - - uses: 'actions/github-script@v6' + - uses: 'actions/github-script@v7' with: script: |- const msg =