Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the finetune.py code #180

Open
dafmdev opened this issue Nov 7, 2024 · 2 comments
Open

Question about the finetune.py code #180

dafmdev opened this issue Nov 7, 2024 · 2 comments

Comments

@dafmdev
Copy link

dafmdev commented Nov 7, 2024

Greetings! Why is it necessary to iterate everything? Could a break be used instead of a pass?

for tbatch in tqdm(train_batches.as_numpy_iterator()):
    pass

or

for tbatch in tqdm(train_batches.as_numpy_iterator()):
    break
@rajatsen91
Copy link
Collaborator

Yes it should be a "break" actually. Please submit a PR if you have the bandwidth.

@dafmdev
Copy link
Author

dafmdev commented Nov 27, 2024

I have created the PR. Thank you very much for your answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants