Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Adaptive] TwoPane should be deprecated #1794

Open
ber4444 opened this issue Sep 24, 2024 · 3 comments
Open

[Adaptive] TwoPane should be deprecated #1794

ber4444 opened this issue Sep 24, 2024 · 3 comments
Assignees

Comments

@ber4444
Copy link

ber4444 commented Sep 24, 2024

Description
https://google.github.io/accompanist/api/adaptive/com.google.accompanist.adaptive/-two-pane.html looks very much redundant with ListDetailPaneScaffold (https://developer.android.com/develop/ui/compose/layouts/adaptive/list-detail)

Steps to reproduce

Expected behavior

Additional context

@alexvanyo
Copy link
Collaborator

Thank you for the issue! For some more context of the status here: the functionality of ListDetailPaneScaffold and SupportingPaneScaffold definitely overlap with TwoPane and supercede it for list-detail and supporting pane scenarios, but there's a few use cases that are still unclear.

For example, Jetcaster uses TwoPane for implementing a tabletop layout.

Copy link

github-actions bot commented Nov 9, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label Nov 9, 2024
@alexvanyo alexvanyo removed the stale Stale issues which are marked for closure label Dec 4, 2024
@alexvanyo alexvanyo reopened this Dec 4, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label Jan 19, 2025
@alexvanyo alexvanyo removed the stale Stale issues which are marked for closure label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants