Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hints #83

Open
radarhere opened this issue May 30, 2024 · 4 comments
Open

Type hints #83

radarhere opened this issue May 30, 2024 · 4 comments

Comments

@radarhere
Copy link
Contributor

radarhere commented May 30, 2024

Hi. Just wondering what it would take to add a PEP 561 py.typed file to this project?

I see you have some type hints already. Would you welcome pull requests to improve upon this?
Does atheris aim to continue supporting Python 3.6, or can that be updated now that 3.6 is EOL?
Would a py.typed file be acceptable once pytype passes?

@radarhere
Copy link
Contributor Author

I created #86 to test the waters, and then #87 to add most of the remaining type hints. However, that has yet to be reviewed.

If you are just taking your time to get to it, no problem. However, if you think that it would be better for me to create stubs through https://github.com/python/typeshed, let me know.

@radarhere
Copy link
Contributor Author

I've created python/typeshed#12462

@radarhere
Copy link
Contributor Author

The typeshed issue has now been merged, so https://pypi.org/project/types-atheris/ now exists.

@Avasam
Copy link

Avasam commented Oct 18, 2024

Note to maintainers here: the existence of types-atheris does not invalidate this issue! It would be better for type annotations to come from first-party.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants