Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cisco ASA generator has no way to enable ipv6 address processing #252

Open
hkam40k opened this issue Mar 18, 2021 · 2 comments
Open

Cisco ASA generator has no way to enable ipv6 address processing #252

hkam40k opened this issue Mar 18, 2021 · 2 comments

Comments

@hkam40k
Copy link

hkam40k commented Mar 18, 2021

Hi, I came across a curious bug(?) in the Cisco ASA generator, where the code seems to have hardcoded that it only processes ipv4 addresses, although the support for ipv6 is also there and it works, as long as the hardcoded part is modified a bit. A bug, unfinished feature, or intentionally left unused (why?)? I could see the Cisco ASA generator utilizing same header keys as the Cisco generator here to optionally process ipv6 also.

Passing the address family should happen here, but since it is omitted, the default value of 4 is always used: https://github.com/google/capirca/blob/master/capirca/lib/ciscoasa.py#L342

@hkam40k
Copy link
Author

hkam40k commented Apr 13, 2021

Hi,

If you agree that this is a bug and not on purpose, then would a PR on this be appreciated, or do you prefer to fix it within your team?

@abhindes
Copy link
Collaborator

Hi,

This seems to be a bug, feel free to send a PR along that fixes the issue, that would be much appreciated, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants