Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Lua Code Generator using IR #6926

Closed
dbaileychess opened this issue Nov 16, 2021 · 4 comments
Closed

Implement Lua Code Generator using IR #6926

dbaileychess opened this issue Nov 16, 2021 · 4 comments
Assignees

Comments

@dbaileychess
Copy link
Collaborator

Reference: #6428 (comment)

@dbaileychess dbaileychess self-assigned this Nov 16, 2021
@dbaileychess
Copy link
Collaborator Author

I'm just marking down things I noticed when implementing this. I haven't investigated these in depth, just wanted to keep track of them.

  • Documentation strings don't seem to be populated.
  • The sizes of the BaseType are not specified. I know I can imply them, but its probably better if they were explicitly stated.
  • There is no information on where to place the generated files (i.e., the -o prefix). Perhaps that should be out of band, but just making note.

@dbaileychess
Copy link
Collaborator Author

  • Declaring file is just the root schema file, not the file it was defined in.
  • I don't see any way to get namespace, apart from being encoded in the object names themselves.

@dbaileychess
Copy link
Collaborator Author

  • I didn't see any padding info for structures.

@dbaileychess
Copy link
Collaborator Author

Solved some of me own issues.

Documentation strings don't seem to be populated.

Need to implicitly set --bfbs-comments

Declaring file is just the root schema file, not the file it was defined in.

I didn't look at a good example, it is the correct declaring file.

I don't see any way to get namespace, apart from being encoded in the object names themselves.

This should be fine as long as the format of dotted namespaces stays the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant