Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to proto api v2 #97

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ilaleksin
Copy link

@ilaleksin ilaleksin commented Sep 3, 2023

This PR addresses upgrade from github.com/golang/protobuf to google.golang.org/protobuf/proto

Changes:

  • generate file descriptors of dependecies with v2 protoreflect API
  • empty message v1 -> empty message v2
  • significant update end-two-end-grpc-gateway example. It doesn't affect the logic, the example still works locally (i.e. steps from README return extected responses)

@google-cla
Copy link

google-cla bot commented Sep 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@LorenzHW
Copy link
Collaborator

@ilaleksin thanks for the contribution. Can you make sure that the test suite ran once as part of this PR. The GitHub action should have been triggered as in this PR and results should be green.

Maybe we need to adapt the Github action to have:

  pull_request:
    branches:
      - main

@LorenzHW
Copy link
Collaborator

@fideltak hmm weird. Still not triggering. You ran tests locally I assume? Will take a look at the PR in the upcoming days.

@ilaleksin
Copy link
Author

ilaleksin commented Oct 12, 2023

Hey @LorenzHW,
Unit tests for this PR will run after approval from a maintainer.

Could you launch the workflow?

@LorenzHW
Copy link
Collaborator

Alright, thanks @ilaleksin. I am sorry, I am so swamped with life right now, that I haven't found the time to review :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants