-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to proto api v2 #97
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ilya Alexin <[email protected]>
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@ilaleksin thanks for the contribution. Can you make sure that the test suite ran once as part of this PR. The GitHub action should have been triggered as in this PR and results should be green. Maybe we need to adapt the Github action to have:
|
@fideltak hmm weird. Still not triggering. You ran tests locally I assume? Will take a look at the PR in the upcoming days. |
Hey @LorenzHW, Could you launch the workflow? |
Alright, thanks @ilaleksin. I am sorry, I am so swamped with life right now, that I haven't found the time to review :( |
This PR addresses upgrade from github.com/golang/protobuf to google.golang.org/protobuf/proto
Changes: