-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Yarn PNP #563
Comments
This would be really nice, probably the only thing preventing me from using yarn pnp. |
made a very hacky bash script to setup a new project using gts and yarn pnp you can setup a new project with most things seem to be working except for eslint-plugin-node from what it looks like |
After doing some more research on the matter I'm going to attempt to get eslint-plugin-node working with the script, no promises that it will work, but if it does, gts will be "fully working" in a sense. |
So the issue with the eslint plugins and other things is that due to how yarn's pnp works, they have to be under dependencies of the root project, i.e the project you're making that depends on gts, otherwise since your extending their configuration(s), it won't be able to access them currently. |
Decided to go all out and made a template repo that sets up mostly everything for you, just need to run a few commands and you have a fully setup yarn + gts env. https://github.com/xpyxel/gts-pnp |
was this issue ever resolved? trying to set up 1 $ yarn lint
version: 16
/Users/jaismith/Developer/doc/trailhead/.pnp.cjs:33932
throw firstError;
^
Error: Qualified path resolution failed - none of those files can be found on the disk.
Source path: /Users/jaismith/Developer/doc/trailhead/node_modules/eslint/bin/eslint
Not found: /Users/jaismith/Developer/doc/trailhead/node_modules/eslint/bin/eslint
Not found: /Users/jaismith/Developer/doc/trailhead/node_modules/eslint/bin/eslint.js
Not found: /Users/jaismith/Developer/doc/trailhead/node_modules/eslint/bin/eslint.json
Not found: /Users/jaismith/Developer/doc/trailhead/node_modules/eslint/bin/eslint.node
at Function.external_module_.Module._resolveFilename (/Users/jaismith/Developer/doc/trailhead/.pnp.cjs:33931:55)
at Function.external_module_.Module._load (/Users/jaismith/Developer/doc/trailhead/.pnp.cjs:33730:48)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:79:12)
at node:internal/main/run_main_module:17:47 |
@jaismith i ended up just making my own thing similar: https://github.com/stacknine/ts-pnp |
There's a couple spots that need patches:
extends: ./node_modules/gts
, etc)execa
calls tonode ./node_modules/*
Implementation thoughts:
.yarn
? Hacky.The text was updated successfully, but these errors were encountered: