Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-unpublished-import no longer throws an error by default #887

Open
IchordeDionysos opened this issue Jun 12, 2024 · 3 comments
Open

no-unpublished-import no longer throws an error by default #887

IchordeDionysos opened this issue Jun 12, 2024 · 3 comments

Comments

@IchordeDionysos
Copy link

IchordeDionysos commented Jun 12, 2024

Steps to reproduce:

  1. Run npx gts init
  2. Use default options
  3. Add the following code at the top of index.ts
import * as gts from 'gts';
  1. Run npm run lint

Expected behaviour

It throws an error:

1:22  error  "gts" is not published  n/no-unpublished-import

Actual behaviour

There is no error being thrown.

Additional information

When adding src to the files array in the package.json, the behaviour is fixed, though it is debatable whether this is a desirable fix.

  "files": [
    "build/src",
    "src"
  ],
@tonycoco
Copy link
Contributor

I'll look into this.

@IchordeDionysos
Copy link
Author

@tonycoco
Copy link
Contributor

Interesting but in my initial test that doesn't seem to work in our case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants