Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Regression in GatherIndexN #2382

Open
Mousius opened this issue Nov 19, 2024 · 1 comment · May be fixed by #2383
Open

Performance Regression in GatherIndexN #2382

Mousius opened this issue Nov 19, 2024 · 1 comment · May be fixed by #2383

Comments

@Mousius
Copy link
Contributor

Mousius commented Nov 19, 2024

In numpy/numpy#25934, we see up to 3x slow down in gathering loads on AArch64 when using Highway.

I believe this is due to #2116, which seems to have subtly changed the code path.
This was referenced Nov 19, 2024
Open
Open
@jan-wassenberg
Copy link
Member

Good catch, thanks for noticing this change.
It seems if() indeed has better codegen: https://gcc.godbolt.org/z/vsKdTYYj1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert to previous logic for GatherIndexN Mousius/highway
2 participants
@Mousius @jan-wassenberg