Improve MulEven performance for RVV #2334
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the performance of
MulEven
by using masked multiplication instead of merging the results after computing the higher and lower parts.A similar optimization can be applied to the
MulOdd
operator, though this would require aMaskedMulHighOr
operator, which is currently unavailable.For 8-bit elements,
MulEven
currently uses the immediate value 0x5555, which requires two instructions to construct on RISC-V. There may be a potential optimization by constructing the mask manually instead of relying onDup128MaskFromMaskBits
, allowing the use of the smaller immediate 0x55. However, it's just a scalar instruction, so I am unsure if we want to do so.