Added MinMagnitude and MaxMagnitude ops #2353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnplatts
force-pushed
the
hwy_min_max_mag_101024
branch
from
18c9d93
to
620fec7
Compare
jan-wassenberg
approved these changes
Oct 12, 2024
| const auto abs_a = Abs(a); | ||
| const auto abs_b = Abs(b); | ||
| return IfThenElse(Lt(abs_a, abs_b), a, | ||
| Min(IfThenElse(Eq(abs_a, abs_b), a, b), b)); |
There was a problem hiding this comment.
Neat trick to match the x86 |a| < |b|, |b| < |a|, min(a, b) cases :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the MinMagnitude and MaxMagnitude ops as the upcoming AVX10.2 instruction set will have VMINMAXPH/VMINMAXPS/VMINMAXPD instructions that can carry out the MinMagnitude and MaxMagnitude operations for F16/F32/F64 vectors.