Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are custom attribute types in the roadmap anymore? #164

Closed
botverse opened this issue Oct 16, 2018 · 3 comments · May be fixed by #169
Closed

Are custom attribute types in the roadmap anymore? #164

botverse opened this issue Oct 16, 2018 · 3 comments · May be fixed by #169

Comments

@botverse
Copy link

botverse commented Oct 16, 2018 •
edited
Loading

@shwoodard first thanks for the fantastic work on this.

Now just to clarify:

  • Are custom attribute types out of the scope now?
  • When can we expect them to be around?

In #163 @henrmota seems to have fixed the problem but in #159 you seem to have removed them from even the README.

I think I can say that there are some users interested on this based on the issues open atm.

Cheers.
@henrmota
Copy link

Hi, I hope my PR is merged, thankyou @botverse

@botverse
Copy link
Author

@henrmota this also seems to work for me: db5a629

just testing for the struct to be of type json.Unmashaler otherwise trying to unmarshal it as a node

@mkarlesky mkarlesky mentioned this issue Nov 10, 2018
Closed
@michele michele mentioned this issue Mar 5, 2019
Open
@botverse
Copy link
Author

Closing as project is dead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve handleStruct to use struct's own Unmarshaler if it is available michele/go.jsonapi
2 participants
@botverse @henrmota