Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows builds are a disaster #151

Open
jhughes2112 opened this issue Sep 13, 2024 · 3 comments
Open

Windows builds are a disaster #151

jhughes2112 opened this issue Sep 13, 2024 · 3 comments

Comments

@jhughes2112
Copy link

I've done this before a year ago, figured out the magic incantation to get Windows builds working. I'm trying to do it again (lost access to that wiki page), and I'm struggling, again. Bazel is a garbage system. I'm having to hack the python_configure.bzl to get it to recognize that Python.exe is actually an executable. PLEASE somebody actually start with a fresh Windows VM and outline the proper steps. So frustrating.

@p0358
Copy link

p0358 commented Sep 13, 2024

It's from a fork, but maybe you'd have some luck with this: https://github.com/TFORevive/vaudio_lyra?tab=readme-ov-file#compile-on-windows

(and yes Bazel is pain, but I think Lyra might also be needing some older version or something)

@jhughes2112
Copy link
Author

Thanks much for the link, that'll help. I've gotten pretty far using Git Bash as the environment, MSYS was not doing the right thing for me. Running in a Windows cmd shell absolutely did not work. Newest versions of Bazel have very-breaking changes, and it seems pytorch depends on a newer version of Bazel than 5.0.0 that was originally used for Lyra. It's great tech, but the build process is garbage. There are some good things in that repo you mentioned. I'll post an update here for posterity once I get things working.

@jhughes2112
Copy link
Author

Leaving this here for future Windows devs. Lyra is very sensitive to Bazel versions. 5.0.0 did not work, but 5.3.2 does, 7.3.1 does not. Build systems are supposed to be agnostic to what they build. Sigh. Seems to me Bazel is increasing fragility of codebases, but hey, nobody asked my opinion. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants