Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: visualize FAIL_AND_CONTINUE as red color on the web frontend. #1019

Closed
antonysigma opened this issue Aug 18, 2022 · 2 comments
Closed

Comments

@antonysigma
Copy link

@fahhem and @arsharma1 A follow-up question: if I enable the web frontend, will it show a green color (indicating a PASS) or a red color?

I can confirm that OutputToJSON returns the FAIL_AND_CONTINUE state, but not sure how the web frontend will behave.

Originally posted by @antonysigma in #616 (comment)

The context: I wish to return htf.PhaseResult.FAIL_AND_CONTINUE without any @htf.measures() decorators in a test phase.

The bug: OutputToJSON returns the FAIL_AND_CONTINUE state, but the web frontend is still showing a green color of the test, indicating a false positive.

@lalten
Copy link
Contributor

lalten commented Sep 1, 2022

Try #1020, that probably does what you want :)

@dbhatman
Copy link
Collaborator

Yes, after lalten@'s change this should generally work when you enable the Web GUI! See #1020 which has a quick screen shot though not specifically of the red with FAIL but that is the expected behavior! We should also probably include some screen shots as part of some user docs (i.e. #44).

Going to close this out. Please reopen or create a new issue if you have more followups!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants