Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introspector: use introspector to get harness/source pairs by default #611

Merged
merged 3 commits into from
Sep 14, 2024

Conversation

DavidKorczynski
Copy link
Collaborator

Ref: #525

@DavidKorczynski
Copy link
Collaborator Author

This performs a lot better than our existing automated setup, but there are still three discrepancies between the manually generated ones from #524:

"project": "librawspeed"
"target_name": "/src/librawspeed/fuzz/librawspeed/codes/PrefixCodeDecoder/Dual.cpp"
"target_path": "/src/librawspeed/fuzz/librawspeed/codes/PrefixCodeDecoder/Dual.cpp"


"target_name": "fuzztest"
"target_name": "fuzztest_proto2_static"
"target_path": "/src/nanopb/tests/fuzztest/fuzztest.c"


"project": "proftpd"
"target_name": "fuzzer"
"target_path": "/src/fuzzer.c"

These will be dealt with on the introspector side -- but this still performs a lot better than the current status quo -- this is good to go.

Finally, there are some benign discrepancies to #524 in that sometime the current heuristic will select other harnesses than the manually selected ones. In general, this is no problem. However, there are some potential cases where we may want to select a specific harness within a given project if the given harness has a wider (or different) linkage. An example here is abseil-cpp where the better harness to taget is string_utilities_fuzzer as it includes more sources from the source tree: https://github.com/google/oss-fuzz/blob/master/projects/abseil-cpp/BUILD

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

/gcbrun skip

@AdamKorcz AdamKorcz merged commit 6fc5806 into main Sep 14, 2024
6 checks passed
@AdamKorcz AdamKorcz deleted the harden-cov-collection branch September 14, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants