Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the minimum change threshold option in the Compressed Size action #10202

Open
1 task
eugene-manuilov opened this issue Feb 11, 2025 · 2 comments
Open
1 task
Labels
Good First Issue Good first issue for new engineers P2 Low priority Team M Issues for Squad 2 Type: Infrastructure Engineering infrastructure & tooling

Comments

@eugene-manuilov
Copy link
Collaborator

Feature Description

In order to reduce noise in our PRs, we need to set a threshold for the Compressed Size action. The threshold should be big enough to ignore all valid changes that we have in our PRs and flag only significant changes in bundle sizes.

https://github.com/preactjs/compressed-size-action/tree/v2/?tab=readme-ov-file#increasing-the-required-threshold


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The Compressed Size action is updated to ignore all changes under 200kb

Implementation Brief

  • Add the minimum-change-threshold option to the preactjs/compressed-size-action@v2 step with the 204800 value (200kb)
    - uses: preactjs/compressed-size-action@v2
    with:
    repo-token: '${{ secrets.GITHUB_TOKEN }}'
    pattern: './dist/assets/**/*.{css,js}'
    # The sub-match below will be replaced by asterisks.
    # The length of 20 corresponds to webpack's `output.hashDigestLength`.
    strip-hash: "([a-f0-9]{20})(?:\\.min)?\\.(?:css|js)$"

Test Coverage

  • N/A

QA Brief

Changelog entry

@eugene-manuilov eugene-manuilov added Good First Issue Good first issue for new engineers P2 Low priority Type: Infrastructure Engineering infrastructure & tooling labels Feb 11, 2025
@eugene-manuilov
Copy link
Collaborator Author

@aaemnnosttv / @techanvil / @tofumatt / @nfmohit do you mind reviewing this IB?

@techanvil techanvil self-assigned this Feb 11, 2025
@techanvil
Copy link
Collaborator

Sure, let's see how we get on with this threshold.

IB ✅

@techanvil techanvil removed their assignment Feb 11, 2025
@ivonac4 ivonac4 added the Team M Issues for Squad 2 label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good first issue for new engineers P2 Low priority Team M Issues for Squad 2 Type: Infrastructure Engineering infrastructure & tooling
Projects
None yet
Development

No branches or pull requests

3 participants