Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when user with existing GfW ads account tries to enter same ID in Ads module manual setup #10257

Open
1 task
zutigrm opened this issue Feb 21, 2025 · 1 comment
Assignees
Labels
P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@zutigrm
Copy link
Collaborator

zutigrm commented Feb 21, 2025

Feature Description

Based on the latest update in Figma when user, who has existing GfW active and connected Ads ID, tries to input same ID manually during the Ads setup, we should show warning and disable the button as shown in the referenced design


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • When use tries to add Ads ID, in the manual setup form, that is also connected in Google for WooCommerce plugin new notice is shown bellow the field and complete setup CTA is disabled

Implementation Brief

We need to extract the tag ID from GfW, Evan checked the option, and The tag ID that is put into gtag on the frontend is from the ads_conversion_action option, which is an array that has the tag under conversion_id . See \Automattic\WooCommerce\GoogleListingsAndAds\Google\GlobalSiteTag. This should be exposed in the inline data and retrieved by the selector

Test Coverage

QA Brief

Changelog entry

@zutigrm zutigrm added P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature labels Feb 21, 2025
@zutigrm zutigrm assigned zutigrm and unassigned zutigrm Feb 21, 2025
@10upsimon 10upsimon self-assigned this Feb 25, 2025
@10upsimon
Copy link
Collaborator

@zutigrm this LGTM, I am going to pick this up and take on the IB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants