Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

grep finder does not handle multiline goog.provide statments #7

Open
jgiles opened this issue Jul 26, 2014 · 1 comment
Open

grep finder does not handle multiline goog.provide statments #7

jgiles opened this issue Jul 26, 2014 · 1 comment
Labels

Comments

@jgiles
Copy link
Contributor

jgiles commented Jul 26, 2014

In the case of deep namespaces and long class names, goog.provide statements are sometimes broken across lines:

goog.provide(
    'this.is.a.very.very.very.very.long.ClassNameThatNeedsWrapping');

The grep finder currently just drops these. Addressing this issue across all platforms (without introducing a dependency on less-common options or utilities) would be difficult, so this will likely be left unfixed.

The upcoming native Node search finder (#5) should handle this case.

@jgiles jgiles added bug and removed wontfix labels Jul 26, 2014
@jgiles
Copy link
Contributor Author

jgiles commented Jul 26, 2014

Correction, this will probably be fixed. The grep finder will just delegate to the pure-Node file processing logic in this case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant