Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Support for VkPhysicalDeviceProtectedMemoryFeatures should be properly queried before being used #164

Open
hevrard opened this issue Jul 1, 2020 · 0 comments

Comments

@hevrard
Copy link
Contributor

hevrard commented Jul 1, 2020

The device creation in CreateDeviceForSwapchain seems to assume that the extension offering VkPhysicalDeviceProtectedMemoryFeatures is always supported:

https://github.com/google/vulkan_test_applications/blob/master/vulkan_helpers/helper_functions.cpp#L643-L651

I think the support for this extension should be queried with vkGetPhysicalDeviceFeatures2, and it should not be used unless it is supported. Swiftshader reports that it does not support this extension, and fails when a CreateDeviceInfo has a pNext with a VkPhysicalDeviceProtectedMemoryFeatures struct.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant