Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] channel (and func input) flopping should be resolved in a codegen pass #1803

Open
allight opened this issue Dec 18, 2024 · 0 comments
Open

[enhancement] channel (and func input) flopping should be resolved in a codegen pass #1803

allight opened this issue Dec 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@allight
Copy link
Collaborator

allight commented Dec 18, 2024

What's hard to do? (limit 100 words)

Resolution of what type of flopping/buffering to add to ports is currently done in a somewhat ad-hoc manner in block_conversion.cc. This is difficult to test and complicated.

Current best alternative workaround (limit 100 words)

N/A

Your view of the "best case XLS enhancement" (limit 100 words)

This resolution should really be done as a resolution pass performed prior to block conversion which would make testing easier and keep everything much more self-contained. As codegen refactor continues this should be one of the things changed.
@allight allight added the enhancement New feature or request label Dec 18, 2024
copybara-service bot pushed a commit that referenced this issue Dec 19, 2024
@allight @copybara-github
Mark channel flop types in a pass
b861cab 
This is more in line with best practices than doing it during block conversion itself.

Bug: #1803
PiperOrigin-RevId: 707951892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@allight