From c4f3c3f079fccd42d36faffedf93efc3f3b4e818 Mon Sep 17 00:00:00 2001
From: ikuleshov <ikuleshov@google.com>
Date: Mon, 13 Jan 2025 10:29:46 +0000
Subject: [PATCH] screen_view & ad_impression are no longer reserved event
 names

---
 .../schemas/eventTypes/eventDefinitions.ts    |  2 --
 src/components/ga4/EventBuilder/event.ts      | 30 -------------------
 src/components/ga4/EventBuilder/types.ts      |  2 --
 3 files changed, 34 deletions(-)

diff --git a/src/components/ga4/EventBuilder/ValidateEvent/schemas/eventTypes/eventDefinitions.ts b/src/components/ga4/EventBuilder/ValidateEvent/schemas/eventTypes/eventDefinitions.ts
index 65a1024e..920c1212 100644
--- a/src/components/ga4/EventBuilder/ValidateEvent/schemas/eventTypes/eventDefinitions.ts
+++ b/src/components/ga4/EventBuilder/ValidateEvent/schemas/eventTypes/eventDefinitions.ts
@@ -1,13 +1,11 @@
 // Event and required property mapping
 
 export const eventDefinitions = {
-    "ad_impression": [],
     "add_payment_info": ["value", "items"],
     "add_shipping_info": ["value", "items"],
     "add_to_cart": ["value", "items"],
     "add_to_wishlist": ["value", "items"],
     "begin_checkout": ["value", "items"],
-    "campaign_details": [],
     "earn_virtual_currency": [],
     "generate_lead": ["value"],
     "join_group": [],
diff --git a/src/components/ga4/EventBuilder/event.ts b/src/components/ga4/EventBuilder/event.ts
index 5704422b..eb2ac181 100644
--- a/src/components/ga4/EventBuilder/event.ts
+++ b/src/components/ga4/EventBuilder/event.ts
@@ -50,19 +50,6 @@ const eventFor = (
 
 const custom_event = eventFor(EventType.CustomEvent, [Category.Custom], [], [])
 
-const ad_impression = eventFor(
-    EventType.AdImpression,
-    [Category.AllApps],
-    [
-      stringParam("ad_platform", "MoPub"),
-      stringParam("ad_source", "AdColony"),
-      stringParam("ad_format", "Banner"),
-      stringParam("ad_unit_name", "Banner_03"),
-      stringParam("currency", "USD"),
-      numberParam("value", 	3.99),
-    ]
-)
-
 const add_payment_info = eventFor(
   EventType.AddPaymentInfo,
   [Category.RetailEcommerce],
@@ -172,19 +159,6 @@ const begin_checkout = eventFor(
   ]
 )
 
-const campaign_details = eventFor(
-    EventType.CampaignDetails,
-    [Category.AllApps],
-    [
-      stringParam("campaign_id", "SUMMER_FUN"),
-      stringParam("campaign", "Summer_fun"),
-      stringParam("source", "google"),
-      stringParam("medium", "cpc"),
-      stringParam("term", "summer+travel"),
-      stringParam("content", "logolink"),
-    ]
-)
-
 const earn_virtual_currency = eventFor(
   EventType.EarnVirtualCurrency,
   [Category.AllApps],
@@ -524,8 +498,6 @@ export const suggestedEventFor = (eventType: EventType): Event2 => {
     case EventType.CustomEvent:
       return custom_event
 
-    case EventType.AdImpression:
-      return ad_impression
     case EventType.AddPaymentInfo:
       return add_payment_info
     case EventType.AddShippingInfo:
@@ -536,8 +508,6 @@ export const suggestedEventFor = (eventType: EventType): Event2 => {
       return add_to_wishlist
     case EventType.BeginCheckout:
       return begin_checkout
-    case EventType.CampaignDetails:
-      return campaign_details
     case EventType.EarnVirtualCurrency:
       return earn_virtual_currency
     case EventType.GenerateLead:
diff --git a/src/components/ga4/EventBuilder/types.ts b/src/components/ga4/EventBuilder/types.ts
index f8d108ea..b853bd72 100644
--- a/src/components/ga4/EventBuilder/types.ts
+++ b/src/components/ga4/EventBuilder/types.ts
@@ -28,13 +28,11 @@ export enum Category {
 
 export enum EventType {
   CustomEvent = "custom_event",
-  AdImpression = "ad_impression",
   AddPaymentInfo = "add_payment_info",
   AddShippingInfo = "add_shipping_info",
   AddToCart = "add_to_cart",
   AddToWishlist = "add_to_wishlist",
   BeginCheckout = "begin_checkout",
-  CampaignDetails = "campaign_details",
   EarnVirtualCurrency = "earn_virtual_currency",
   GenerateLead = "generate_lead",
   JoinGroup = "join_group",