Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test the Auth Samples in Cloud Build #1487

Open
lqiu96 opened this issue Aug 28, 2024 · 1 comment
Open

Test the Auth Samples in Cloud Build #1487

lqiu96 opened this issue Aug 28, 2024 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@lqiu96
Copy link
Contributor

lqiu96 commented Aug 28, 2024

The Auth Library has a few handwritten samples (https://github.com/googleapis/google-auth-library-java/tree/main/samples/snippets) that should be tested in the CI. We should ensure that these samples (which are published to our docs) work with the latest auth code changes.
@lqiu96 lqiu96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 28, 2024
@lqiu96
Copy link
Contributor Author

lqiu96 commented Sep 6, 2024

Samples to test: AuthenticateImplicitWithAdc.java, IdTokenFromImpersonatedCredentials.java, and AuthenticateImplicitWithAdc.java. The other samples do not need to be tested and can continue to live in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lqiu96