Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigtable: retry request on retryable error messages #10207

Open
bhshkh opened this issue May 16, 2024 · 9 comments · May be fixed by #11477
Open

bigtable: retry request on retryable error messages #10207

bhshkh opened this issue May 16, 2024 · 9 comments · May be fixed by #11477
Assignees
@bhshkh
Labels
api: bigtable Issues related to the Bigtable API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@bhshkh
Copy link
Contributor

bhshkh commented May 16, 2024

Client

Bigtable

Additional context

#9673 (comment)

Creating this issue to track the work of finding out if there are any Bigtable retryable error messages which are not been retried,
@bhshkh bhshkh added the triage me I really want to be triaged. label May 16, 2024
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label May 16, 2024
@bhshkh bhshkh mentioned this issue May 16, 2024
Merged
@fsaintjacques
Copy link

Is it possible to retry Internal errors? I have a bunch of nightly tasks that sometimes fail due to this. Because we don't have access to the raw gRPC client there's nothing I can do but post here, or roll my own.

@fsaintjacques
Copy link

@bhshkh ping

@bhshkh
Copy link
Contributor Author

bhshkh commented Sep 28, 2024

Will pick this up soon.

@fsaintjacques
Copy link

Any ETA @bhshkh

@Yoshiji
Copy link

Yoshiji commented Jan 17, 2025

Any update on this?

@bhshkh
Copy link
Contributor Author

bhshkh commented Jan 21, 2025

@fsaintjacques Can you share the complete error message that you are seeing in the nightly?

@bhshkh bhshkh linked a pull request Jan 21, 2025 that will close this issue
Open
@bhshkh
Copy link
Contributor Author

bhshkh commented Jan 21, 2025

I have created the linked pull request to retry RST stream internal errors.

@fsaintjacques
Copy link

We will try to capture one, but really this needs a gax.Retry on codes.Internal.

@fsaintjacques
Copy link

gax.Invoke: t.table.ReadRows: rpc error: code = Internal desc = unexpected EOF

@bhshkh bhshkh added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhshkh bhshkh

Labels
api: bigtable Issues related to the Bigtable API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(bigtable): Retry RST stream errors bhshkh/google-cloud-go
3 participants
@fsaintjacques @Yoshiji @bhshkh