Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query stream resumption #889

Open
daniel-sanche opened this issue Mar 13, 2024 · 1 comment
Open

Fix query stream resumption #889

daniel-sanche opened this issue Mar 13, 2024 · 1 comment
Assignees
Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone

Comments

@daniel-sanche
Copy link
Contributor

RunQuery and RunAggregationQuery are stream rpcs, meaning they return a generator that can be yielded from.

They currently both have some logic in place to detect when an exception is raised, and attempt to silently re-start the stream when it fails, while still presenting the user with a unified generator (RunQuery, RunAggregationQuery implementation)

Unfortunately, these implementations don't modify the query request, meaning the user yeilding from the generator will see repeated results, with no indication taht anything went wrong

We should replace this custom logic with the new streaming retries functionality in api_core, and make sure stream errors are handled cleanly

@daniel-sanche daniel-sanche added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 13, 2024
@daniel-sanche daniel-sanche added this to the Retry Audit milestone Mar 13, 2024
@daniel-sanche daniel-sanche self-assigned this Mar 13, 2024
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Mar 13, 2024
@daniel-sanche
Copy link
Contributor Author

This is part of the larger retry cleanup work: https://github.com/googleapis/python-firestore/milestone/4

@daniel-sanche daniel-sanche added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

1 participant