Fix query stream resumption #889
Labels
api: firestore
Issues related to the googleapis/python-firestore API.
priority: p3
Desirable enhancement or fix. May not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
RunQuery and RunAggregationQuery are stream rpcs, meaning they return a generator that can be yielded from.
They currently both have some logic in place to detect when an exception is raised, and attempt to silently re-start the stream when it fails, while still presenting the user with a unified generator (RunQuery, RunAggregationQuery implementation)
Unfortunately, these implementations don't modify the query request, meaning the user yeilding from the generator will see repeated results, with no indication taht anything went wrong
We should replace this custom logic with the new streaming retries functionality in api_core, and make sure stream errors are handled cleanly
The text was updated successfully, but these errors were encountered: