Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/request is added as dependency instead of dev dependency #136

Open
7 tasks done
josephdpurcell-five9 opened this issue Dec 14, 2024 · 0 comments
Open
7 tasks done

Comments

@josephdpurcell-five9
Copy link

Please make sure you have searched for information in the following guides.

Link to the code that reproduces this issue. A link to a public Github Repository or gist with a minimal reproduction.

https://github.com/googleapis/retry-request/blob/main/package.json#L33

A step-by-step description of how to reproduce the issue, based on the linked reproduction.

  1. npm i retry-request
  2. notice @types/request is installed

A clear and concise description of what the bug is, and what you expected to happen.

Expectation is @types/request is not installed

A clear and concise description WHY you expect this behavior, i.e., was it a recent change, there is documentation that points to this behavior, etc. **

I expect this behavior because @types packages generally are for types and not required for the function of the package.

In this particular case, I'm trying to install form-data v4 which is required by gaxios 6.7.1 (see https://github.com/googleapis/gaxios/blob/v6.7.1/package.json#L62 but more specifically https://github.com/googleapis/gaxios/blob/v6.7.1/src/gaxios.ts#L336). However, I cannot do that ultimately because retry-request:

node_modules/@types/request/node_modules/form-data
  form-data@"^2.5.0" from @types/[email protected]
  node_modules/@types/request
    @types/request@"^2.48.8" from [email protected]
    node_modules/@google-cloud/tasks/node_modules/retry-request
      retry-request@"^7.0.0" from [email protected]
      node_modules/@google-cloud/tasks/node_modules/google-gax
        google-gax@"^4.0.4" from @google-cloud/[email protected]
        node_modules/@google-cloud/tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant