Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify update of cloudbuild-*.yaml files in next release (after 2.31.0) #2327

Closed
mpeddada1 opened this issue Jan 2, 2024 · 1 comment
Closed

Verify update of cloudbuild-*.yaml files in next release (after 2.31.0) #2327

mpeddada1 opened this issue Jan 2, 2024 · 1 comment
Assignees
@mpeddada1
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@mpeddada1
Copy link
Contributor

The cloudbuild yaml files are set up to be updated by release-please using a combination of inline annotations (example) and the extra-files settings in #2326.

Similar to the observations in googleapis/java-shared-config#730, it is likely that these versions won't get automatically updated in the currently open release PR since the changes happened after the PR was opened.

In the next SNAPSHOT and non SNAPSHOT release PR, we need to make sure that these versions are correctly updated
@mpeddada1 mpeddada1 added the type: cleanup An internal cleanup or hygiene concern. label Jan 2, 2024
@mpeddada1 mpeddada1 self-assigned this Jan 2, 2024
@mpeddada1 mpeddada1 added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Jan 2, 2024
This was referenced Jan 3, 2024
Merged
Merged
@mpeddada1
Copy link
Contributor Author

Closing issue. The cloudbuild-*.yaml files have been getting updated (#2417).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpeddada1 mpeddada1

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpeddada1