Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: downstream checks are failing #3325

Closed
diegomarquezp opened this issue Oct 29, 2024 · 2 comments
Closed

ci: downstream checks are failing #3325

diegomarquezp opened this issue Oct 29, 2024 · 2 comments
Assignees
@mpeddada1
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 29, 2024
This was referenced Oct 29, 2024
Merged
Merged
@lqiu96
Copy link
Contributor

lqiu96 commented Oct 29, 2024

This seems like a flaky issue with release-please or related.

Pub-Sub v1.134.1 was released via this PR. I don't see the GH tag being created or a comment that says the release script was kicked off.

Seems to be the same case for pubsublite PR and datastore PR.

Perhaps @suztomo or @JoeWang1127 if know if anything changed with the release this cycle?

For a quick fix for these repos, should we manually create a GH tag + branch in those repos?

@diegomarquezp
Copy link
Contributor Author

Thanks @mpeddada1 for creating the tags in these repos!

diegomarquezp added a commit that referenced this issue Oct 30, 2024
@diegomarquezp
chore(hermetic-build): use secure base image hosted in docker.com (#3324
7528039 
)

This PR switches the base images of all the Hermetic Build Docker image
stages to publicly hosted docker images.

The chosen images are mirrored by Airlock or are at least in process of
incorporation.

The choice of OS family is `alpine` for its security-oriented setup. 0
vulnerabilities were found in the public image scan reports
([example](https://hub.docker.com/layers/library/python/3.12.7-alpine3.20/images/sha256-f498302457ec11162f872199b92239c34e1fbcdbc391ff37a4959e820224aa98?context=explore)).

Although several optimizations are possible (see
#3196 and its
intermediate commits), this PR is restricted to the minimal changes to
have a secure base image.

_Notes:_
* Since the UNIX tools are from FreeBSD, the `-d` flag in the `rm`
command is not supported. This is why we removed its usage in the
scripts
* A few downstream checks are failing in other PRs as well. I raised
#3325 to track
this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpeddada1 mpeddada1

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lqiu96 @diegomarquezp @mpeddada1