Skip to content
This repository has been archived by the owner on Dec 7, 2017. It is now read-only.

pip install line from README fails because "lib" already exists in repo #25

Closed
thundergolfer opened this issue Jun 1, 2016 · 3 comments

Comments

@thundergolfer
Copy link

  1. Install App Engine Python SDK
  2. Clone the repo in the README
  3. 'cd appengine-python-flask-skeleton'
  4. 'pip install -r requirements.txt -t lib'

Command fails because lib already contains the dependencies. Wouldn't it be better to specify something like pip install --upgrade -r requirements.txt in the README?

@waprin
Copy link
Contributor

waprin commented Jun 2, 2016

The command doesn't fail for me on OS X, pip 8.1.2 . Can you provide more details about your version of pip, Python, OS etc?

There's also no real need to --upgrade since we're pinning the dependencies anyway.

@thundergolfer

@waprin
Copy link
Contributor

waprin commented Jun 2, 2016

I do see some warnings, but they are just that, warnings. Don't see a need to force replacement given we're pinning dependencies.

I agree it's strange to pre-vendor the dependencies. The reason we do it for these projects is they are used in quickstarts where the repo is directly downloaded, and where we say "just clone then do appcfg.py update", and people don't necessarily see the README.

@waprin
Copy link
Contributor

waprin commented Jun 2, 2016

Will re-open if you have any more comments.

@waprin waprin closed this as completed Jun 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants