From cdd3e8246d305799daacf1de1776a473799c2e35 Mon Sep 17 00:00:00 2001 From: Mark Mandel Date: Sat, 14 Oct 2023 01:11:11 -0700 Subject: [PATCH] Examples: Update readiness and liveness checks. (#821) This adds readiness checks to the xds and relay examples, and updates the liveness checks to be more aggressive than their previous configuration. Also fixed a small formatting issue in the admin docs (newline between tables). Closes #818 --- docs/src/deployment/admin.md | 2 ++ examples/agones-xonotic-relay/proxy-pool.yaml | 9 +++++++++ .../relay-control-plane.yaml | 18 ++++++++++++++++++ examples/agones-xonotic-xds/proxy-pool.yaml | 9 +++++++++ .../agones-xonotic-xds/xds-control-plane.yaml | 9 +++++++++ 5 files changed, 47 insertions(+) diff --git a/docs/src/deployment/admin.md b/docs/src/deployment/admin.md index 3a9c4b5de8..c2d34b02a0 100644 --- a/docs/src/deployment/admin.md +++ b/docs/src/deployment/admin.md @@ -52,6 +52,8 @@ a list of the criteria for each service an provider. | Manage | Provider is ready | | Relay | Provider is ready | | Agent | Provider is ready AND connected to relay | + +
| Provider | Readiness | |----------|--------------------------------------------| diff --git a/examples/agones-xonotic-relay/proxy-pool.yaml b/examples/agones-xonotic-relay/proxy-pool.yaml index ab674c3de4..bddbb2fdca 100644 --- a/examples/agones-xonotic-relay/proxy-pool.yaml +++ b/examples/agones-xonotic-relay/proxy-pool.yaml @@ -48,11 +48,20 @@ spec: - name: RUST_LOG value: info #,quilkin=trace livenessProbe: + periodSeconds: 5 failureThreshold: 3 httpGet: path: /live port: 8000 scheme: HTTP + readinessProbe: + periodSeconds: 1 + failureThreshold: 900 + successThreshold: 1 + httpGet: + path: /ready + port: 8000 + scheme: HTTP ports: - containerPort: 7777 protocol: UDP diff --git a/examples/agones-xonotic-relay/relay-control-plane.yaml b/examples/agones-xonotic-relay/relay-control-plane.yaml index 6abf33b46a..46e59c4f6c 100644 --- a/examples/agones-xonotic-relay/relay-control-plane.yaml +++ b/examples/agones-xonotic-relay/relay-control-plane.yaml @@ -115,11 +115,20 @@ spec: value: info image: us-docker.pkg.dev/quilkin-mark-dev/release/quilkin:0.7.0 livenessProbe: + periodSeconds: 5 failureThreshold: 3 httpGet: path: /live port: 8000 scheme: HTTP + readinessProbe: + periodSeconds: 1 + failureThreshold: 900 + successThreshold: 1 + httpGet: + path: /ready + port: 8000 + scheme: HTTP ports: - containerPort: 7800 protocol: TCP @@ -160,11 +169,20 @@ spec: value: info image: us-docker.pkg.dev/quilkin-mark-dev/release/quilkin:0.7.0 livenessProbe: + periodSeconds: 5 failureThreshold: 3 httpGet: path: /live port: 8000 scheme: HTTP + readinessProbe: + periodSeconds: 1 + failureThreshold: 900 + successThreshold: 1 + httpGet: + path: /ready + port: 8000 + scheme: HTTP serviceAccountName: quilkin-agones --- apiVersion: v1 diff --git a/examples/agones-xonotic-xds/proxy-pool.yaml b/examples/agones-xonotic-xds/proxy-pool.yaml index 560f69aa51..c95b060b9e 100644 --- a/examples/agones-xonotic-xds/proxy-pool.yaml +++ b/examples/agones-xonotic-xds/proxy-pool.yaml @@ -48,11 +48,20 @@ spec: - name: RUST_LOG value: info #,quilkin=trace livenessProbe: + periodSeconds: 5 failureThreshold: 3 httpGet: path: /live port: 8000 scheme: HTTP + readinessProbe: + periodSeconds: 1 + failureThreshold: 900 + successThreshold: 1 + httpGet: + path: /ready + port: 8000 + scheme: HTTP ports: - containerPort: 7777 protocol: UDP diff --git a/examples/agones-xonotic-xds/xds-control-plane.yaml b/examples/agones-xonotic-xds/xds-control-plane.yaml index 0d98162fe6..e4b0d8d973 100644 --- a/examples/agones-xonotic-xds/xds-control-plane.yaml +++ b/examples/agones-xonotic-xds/xds-control-plane.yaml @@ -115,11 +115,20 @@ spec: value: info image: us-docker.pkg.dev/quilkin/release/quilkin:0.7.0 livenessProbe: + periodSeconds: 5 failureThreshold: 3 httpGet: path: /live port: 8000 scheme: HTTP + readinessProbe: + periodSeconds: 1 + failureThreshold: 900 + successThreshold: 1 + httpGet: + path: /ready + port: 8000 + scheme: HTTP ports: - containerPort: 7800 protocol: TCP