Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove async channels for pushing buffers to be sent #1043

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

Jake-Shadle
Copy link
Collaborator

This makes it so that enqueuing buffers to be sent is now done with PendingSends for both io-uring and tokio implementations. This means io-uring no longer needs its own tokio runtime just to drive the channel futures to transition back to sync code. Instead of a single downstream channel that can be picked up by any receiver, the sessionpool now just has a vector of pending sends that it round robins between to spread out downstream sends.

Since I wanted to remove the tokio runtime from the io-uring thread, this also meant I needed to figure out a way to get rid of the shutdown receiver that was also async, so since all loops have a PendingSends now, I just made it so that you can signal the thread that is the receiver for the pending sends to shutdown, consolidating things a bit.

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 93edbbdc-4a8d-450f-8e87-5ded2decc0c0

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/1043/head:pr_1043 && git checkout pr_1043
cargo build

@XAMPPRocky XAMPPRocky merged commit 632ec6a into main Nov 28, 2024
12 checks passed
@Jake-Shadle Jake-Shadle deleted the remove-async-channels branch November 28, 2024 10:56
XAMPPRocky added a commit that referenced this pull request Dec 6, 2024
XAMPPRocky added a commit that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants