Skip to content

Commit

Permalink
Replace RemoveDuplicates with Distinct (#638)
Browse files Browse the repository at this point in the history
* Replace RemoveDuplicates with Distinct

While running bq_to_vcf we get the following message:
BeamDeprecationWarning: RemoveDuplicates is deprecated since 2.12. Use Distinct instead.

* empty commit
becuase Travis webhooks again does not work!!!
  • Loading branch information
samanvp authored Jul 9, 2020
1 parent cc653d7 commit 1a3cf78
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions gcp_variant_transforms/transforms/combine_sample_ids.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ def expand(self, pcoll):
if self._preserve_sample_order:
return (pcoll
| 'GetSampleIds' >> beam.Map(self._get_sample_ids)
| 'RemoveDuplicates' >> beam.RemoveDuplicates()
| 'RemoveDuplicates' >> beam.Distinct()
| 'Combine' >> beam.combiners.ToList()
| 'ExtractUniqueSampleIds'
>> beam.ParDo(self._extract_unique_sample_ids))
else:
return (pcoll
| 'GetSampleIds' >> beam.FlatMap(self._get_sample_ids)
| 'RemoveDuplicates' >> beam.RemoveDuplicates()
| 'RemoveDuplicates' >> beam.Distinct()
| 'Combine' >> beam.combiners.ToList()
| 'SortSampleIds' >> beam.ParDo(sorted))

0 comments on commit 1a3cf78

Please sign in to comment.